-
Notifications
You must be signed in to change notification settings - Fork 270
DOC-5073 added client-specific vector sets example for redis-py #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "description": """ | ||
| Polish-French chemist and physicist. The only person ever to win | ||
| two Nobel prizes for two different sciences. | ||
| """ | ||
| }, | ||
| "Linus Pauling": { | ||
| "born": 1901, "died": 1994, | ||
| "description": """ | ||
| American chemist and peace activist. One of only two people to win two | ||
| Nobel prizes in different fields (chemistry and peace). | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there's a contradiction here. XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really... Marie Curie won Nobels for two different sciences (physics and chemistry). Pauling won one for chemistry and the other for peace (one science, one not). The few other people who have won two Nobels won both of them for the same subject.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sips coffee Ah yes, I see now. As you were.
|
|
||
| The first of these imports is the | ||
| `SentenceTransformer` class, which generates an embedding from a section of text. | ||
| Here, we create an instance of `SentenceTransformer` that uses the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The beginning of a change to first person plural, which goes against our SG. There's quite a bit of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (I think). Good catch - I guess I got desensitised to it by reading it over and over again :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs quite a bit of "point of view" work: 1st person plural to 2nd person. That said, I like the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks @dwdougherty ! |
DOC-5073
All feedback welcome. When we are happy with this, I'll use it as a model for similar pages in the other client sections, as soon as they add support for vector sets.