DOC-5064 improvements to Jedis production usage advice #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dwdougherty
approved these changes
Apr 10, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Just a couple of items to validate. I like the checklist short code! Approving now so you're not held up.
Co-authored-by: David Dougherty <[email protected]>
Contributor
Author
|
Well spotted, @dwdougherty - thanks! |
ggivo
suggested changes
Apr 29, 2025
| JedisClientConfig clientConfig = DefaultJedisClientConfig.builder() | ||
| .connectionTimeoutMillis(2000) | ||
| .socketTimeoutMillis(2000) | ||
| .tcpKeepAlive(true) |
Contributor
There was a problem hiding this comment.
tcpKeepAlive is by default through when using DefaultJedisSocketFactory and is not externally configurable.
DefaultJedisClientConfig does not expose tcpKeepAlive(true) method
Contributor
Author
|
@ggivo Awesome, thanks! I'll merge this now, but please let me know if you think of any other good production advice and I'll add it to the page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-5064
I've added four new short sections, partly based on suggestions in Ricardo Ferreira's recent blog post and an experimental "live" checklist. I've also expanded the description of timeouts a bit. All feedback is welcome, as usual, especially regarding the following points: