Skip to content

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented May 6, 2025

@dwdougherty dwdougherty requested a review from a team May 6, 2025 14:11
@dwdougherty dwdougherty self-assigned this May 6, 2025
@dwdougherty dwdougherty added dev ros 8.0 Redis Open Source 8.0 labels May 6, 2025
Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dwdougherty
Copy link
Collaborator Author

Thanks for the speedy review, @cmilesb!

@dwdougherty dwdougherty merged commit 8bf4c4f into main May 6, 2025
5 checks passed
@dwdougherty dwdougherty deleted the DOC-5202 branch May 6, 2025 14:24
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to check but basically LGTM.

#
# If instead you are interested in using includes to override configuration
# options, it is better to use include as the last line.
# Keep numeric ranges in numeric tree parent nodes of leafs for `x` generations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's written as "leafs" in the original, and so this is intended as it is?


Redis 8.0 deprecates previous Redis and Redis Stack versions.

Stand alone RediSearch, RedisJSON, RedisTimeSeries, and RedisBloom modules are no longer needed as they are now part of Redis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it usually written as one word?

Suggested change
Stand alone RediSearch, RedisJSON, RedisTimeSeries, and RedisBloom modules are no longer needed as they are now part of Redis.
Standalone RediSearch, RedisJSON, RedisTimeSeries, and RedisBloom modules are no longer needed as they are now part of Redis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev ros 8.0 Redis Open Source 8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants