-
Notifications
You must be signed in to change notification settings - Fork 277
DEV: add Redis 8 rel. notes and update configuration pages #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cmilesb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
Thanks for the speedy review, @cmilesb! |
andy-stark-redis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things to check but basically LGTM.
| # | ||
| # If instead you are interested in using includes to override configuration | ||
| # options, it is better to use include as the last line. | ||
| # Keep numeric ranges in numeric tree parent nodes of leafs for `x` generations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's written as "leafs" in the original, and so this is intended as it is?
|
|
||
| Redis 8.0 deprecates previous Redis and Redis Stack versions. | ||
|
|
||
| Stand alone RediSearch, RedisJSON, RedisTimeSeries, and RedisBloom modules are no longer needed as they are now part of Redis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it usually written as one word?
| Stand alone RediSearch, RedisJSON, RedisTimeSeries, and RedisBloom modules are no longer needed as they are now part of Redis. | |
| Standalone RediSearch, RedisJSON, RedisTimeSeries, and RedisBloom modules are no longer needed as they are now part of Redis. |
DOC-5202