Skip to content

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented May 20, 2025

DOC-4805

I've taken this as far as I can by myself. It definitely needs some input from PM and engineering.

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwdougherty The language is mostly OK or easily fixed. However, I agree with you that this really needs some input from an expert to clarify some points, given that it's quite complicated.

@dwdougherty
Copy link
Collaborator Author

dwdougherty commented May 21, 2025

Thank you, @andy-stark-redis! Hopefully somebody from PM and eng., preferably both, will weigh in. 🤞🏻

@dwdougherty
Copy link
Collaborator Author

Hi @adrianoamaral and @raz-mon. This PR still needs to be reviewed by a SME. Hoping one of you can help with that.

@dwdougherty
Copy link
Collaborator Author

Hi @adrianoamaral and @raz-mon. This PR still needs to be reviewed by a SME. Hoping one of you can help with that. If there's somebody else better suited to the task please let me know who that is.

Copy link
Contributor

@raz-mon raz-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 💪
See a few comments

@dwdougherty
Copy link
Collaborator Author

@andy-stark-redis: now that @raz-mon (engineering) has reviewed, please re-review and add your approval. Thanks!

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor glitch plus a couple of suggestions, but basically LGTM. I'll approve to avoid holding you up.

@dwdougherty
Copy link
Collaborator Author

Thanks again, @andy-stark-redis. All suggestions applied.

@dwdougherty
Copy link
Collaborator Author

I'm closing this PR. Because of a large re-org PR that was just merged, it's easier for me just to reissue my changes in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants