-
Notifications
You must be signed in to change notification settings - Fork 281
DEV: FT.AGGREGATE expression precedence #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
andy-stark-redis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwdougherty The language is mostly OK or easily fixed. However, I agree with you that this really needs some input from an expert to clarify some points, given that it's quite complicated.
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
Co-authored-by: andy-stark-redis <[email protected]>
|
Thank you, @andy-stark-redis! Hopefully somebody from PM and eng., preferably both, will weigh in. 🤞🏻 |
|
Hi @adrianoamaral and @raz-mon. This PR still needs to be reviewed by a SME. Hoping one of you can help with that. |
|
Hi @adrianoamaral and @raz-mon. This PR still needs to be reviewed by a SME. Hoping one of you can help with that. If there's somebody else better suited to the task please let me know who that is. |
raz-mon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 💪
See a few comments
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/stopwords.md
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/data/products.txt
Show resolved
Hide resolved
Co-authored-by: Raz Monsonego <[email protected]>
|
@andy-stark-redis: now that @raz-mon (engineering) has reviewed, please re-review and add your approval. Thanks! |
andy-stark-redis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor glitch plus a couple of suggestions, but basically LGTM. I'll approve to avoid holding you up.
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/advanced-concepts/aggregation-syntax.md
Outdated
Show resolved
Hide resolved
Co-authored-by: andy-stark-redis <[email protected]>
|
Thanks again, @andy-stark-redis. All suggestions applied. |
|
I'm closing this PR. Because of a large re-org PR that was just merged, it's easier for me just to reissue my changes in a new PR. |
DOC-4805
I've taken this as far as I can by myself. It definitely needs some input from PM and engineering.