DEV: add generic-ish tab control #1651
Conversation
cmilesb
left a comment
cmilesb
left a comment
There was a problem hiding this comment.
This looks great - I just have one nit to pick. I'm definitely going to be using this in the future.
content/develop/multitabs-demo.md
Outdated
|
|
||
| -tab-sep- | ||
|
|
||
| ## How to Use |
There was a problem hiding this comment.
The spacing here doesn't look great. Does removing the blank line between the heading and the -tab-sep- line fix it, or is this just a hazard of heading padding?
There was a problem hiding this comment.
Thank you, @cmilesb! I appreciate the review.
I'm pretty sure the spacing issue is caused by heading padding. I removed the blank lines before and after -tab-sep- and the spacing stayed the same. Maybe don't use any headings in the tabs.
There was a problem hiding this comment.
There was some extra padding being added in the CSS. I fixed that, but headings still cause a lot of extra top whitespace. I can't really do anything about that without really messing up our site.
There was a problem hiding this comment.
Fair enough, thanks for taking a look anyway.
DOC-5302
Adds a GitHub style tab element. This will be used in the command pages to provide separate containers for the RESP return information. This was requested by PM well over a year ago.
I will delete the multitabs-demo document before merging.