K8s: sys_resource revision #1656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Dougherty <[email protected]>
Co-authored-by: David Dougherty <[email protected]>
Contributor
Contributor
Author
|
@dwdougherty since you originally reviewed the other commit (that gathered a bunch of merge conflicts), could you do a quick approval on this clean branch for me? |
cmilesb
approved these changes
Jun 3, 2025
dwdougherty
reviewed
Jun 3, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
There's some weird overflowing going on. Not sure how to fix this. Seems we've seen this before.
content/operate/kubernetes/deployment/openshift/openshift-cli.md
Outdated
Show resolved
Hide resolved
dwdougherty
approved these changes
Jun 4, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
\0/ no more wonky formatting! :) LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked/clean version of #1509 without the merge conflicts.