Improve heading 3 and heading 4 styles for better visual hierarchy #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add proper sizing and font weights to h3-h6 headings - H3: text-xl (20px) + font-semibold for clear section breaks - H4: text-lg (18px) + font-medium for subsections - H5: text-base (16px) + font-medium for minor headings - H6: text-sm (14px) + font-medium for smallest headings - Consolidate duplicate h1 rules into single declaration - Maintain existing h1 and h2 styling that works well Fixes issue where h3 and h4 headings didn't look like proper headings on the site.
dwdougherty
approved these changes
Jun 24, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
I looked at a few examples, and the change LGTM.
rrelledge
reviewed
Jun 25, 2025
Contributor
|
These heading style changes look good to me, but I would also like to change the margin-top of the headings so it's not as big. It's in the same file, right here: Could we change that mt-16 to something smaller? Ideally something like mt-12 or mt-8? |
Co-authored-by: Rachel Elledge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where h3 and h4 headings didn't look like proper headings on the site.