Implement scrollable code #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dwdougherty
reviewed
Jun 25, 2025
| {{ $lines := .Get "lines" | default "25" }} | ||
| {{ $lineHeight := add (float $lines) 1.5 }} | ||
|
|
||
| <div class="expand-content overflow-auto my-4" style="height: {{ $lineHeight }}lh;"> |
Collaborator
There was a problem hiding this comment.
I suggest trying to use Tailwind CSS site-wide, so, in this case, you could try using the following Tailwind class instead of the style attribute as shown below. Can you give this a try and see if it works?
Suggested change
| <div class="expand-content overflow-auto my-4" style="height: {{ $lineHeight }}lh;"> | |
| <div class="expand-content overflow-auto my-4 h-[{{ $lineHeight }}lh]"> |
Contributor
Author
There was a problem hiding this comment.
I did try that before I opened this PR, and for some reason, it doesn't get picked up, but using the style: version does. I have no idea why.
Collaborator
There was a problem hiding this comment.
It may be that our version of Tailwind doesn't support those kinds of classes. Thank you for trying (and for reading my mind). 🙂
dwdougherty
approved these changes
Jun 26, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Works well. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
{{< scrollable-code lines="10" >}}
Content with many lines here...
{{< /scrollable-code >}}
Ideally used for just code blocks. In theory, you could use this for any content, but I think that would require a lot of re-tooling.