K8s: Add log collector options #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaitlynmichael
commented
Jul 24, 2025
kaitlynmichael
commented
- Replace brief option mentions with complete options table
- Include all 12 available command-line options with descriptions
- Add CLI configuration prerequisite step
- Add RBAC requirements section
- Follows same documentation pattern as other CLI tools
- Replace brief option mentions with complete options table - Include all 12 available command-line options with descriptions - Add CLI configuration prerequisite step - Add RBAC requirements section - Follows same documentation pattern as other CLI tools
Contributor
kaitlynmichael
commented
Jul 24, 2025
kaitlynmichael
commented
Jul 24, 2025
dwdougherty
approved these changes
Jul 24, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Just one nitpick. Otherwise, LGTM. Approving.
Co-authored-by: David Dougherty <[email protected]>
kaitlynmichael
added a commit
that referenced
this pull request
Jul 29, 2025
* K8s: Add comprehensive log collector options documentation - Replace brief option mentions with complete options table - Include all 12 available command-line options with descriptions - Add CLI configuration prerequisite step - Add RBAC requirements section - Follows same documentation pattern as other CLI tools * Apply suggestions from code review * remove 6.2.18 mention * Update content/operate/kubernetes/logs/collect-logs.md Co-authored-by: David Dougherty <[email protected]> --------- Co-authored-by: David Dougherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.