Langcache: Change examples from multitab to local client examples #1915
Conversation
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
LGTM. Wouldn't hurt to have @andy-stark-redis look at the changes as well. That is, if you can wait until tomorrow.
|
|
||
| ```bash | ||
| curl -s -X POST "https://$HOST/v1/caches/$CACHE_ID/entires/search" \ | ||
| {{< clients-example set="langcache_sdk" step="imports_setup" dft_tab_name="cURL" footer="hide" >}} |
There was a problem hiding this comment.
This solution is fine, but just a thought about an alternative: you can override the default tab footer link too, so you could maybe link to the example here? I guess there's no limit to the number of named parameters now, so perhaps there's a way to override the footer link for each language if the quickstart link is a problem?
There was a problem hiding this comment.
Yeah, the quickstart links are the issue. It would be better if I could override all of the links or disable just the quickstart links. As it stands right now, I'm fine with hiding the footer entirely.
Also adds a "footer=hide" option to the client examples to hide the footer, since I couldn't figure out how to hide the footer for specific tabs.