Skip to content

DOC-5654 changed namespace name highlighting #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

DOC-5654 changed namespace name highlighting #2043

merged 1 commit into from
Sep 2, 2025

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Aug 27, 2025 •
edited
Loading

Open to all suggestions about the colour to use for the namespaces, but it should probably not be the same as the surrounding keywords :-)

Staging: Python, Java, C#. Other languages already look OK.

@andy-stark-redis andy-stark-redis requested review from a team and paoloredis August 27, 2025 15:42
@andy-stark-redis andy-stark-redis self-assigned this Aug 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025 •
edited by atlassian bot
Loading

DOC-5654

dwdougherty
dwdougherty approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No axe to grind regarding the color palette.

@paoloredis
Copy link
Collaborator

paoloredis commented Aug 28, 2025

@tylerhutcherson are you happy with this? https://redis.io/docs/staging/DOC-5654-python-import-css/develop/clients/redis-py/amr/#credentialprovider-for-a-service-principal

@andy-stark-redis andy-stark-redis merged commit ba2ffff into main Sep 2, 2025
5 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-5654-python-import-css branch September 2, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@paoloredis paoloredis paoloredis approved these changes

@tylerhutcherson tylerhutcherson Awaiting requested review from tylerhutcherson

Assignees

@andy-stark-redis andy-stark-redis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andy-stark-redis @paoloredis @dwdougherty