DOC-5552 Jedis vector set embedding examples #2142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwdougherty
approved these changes
Sep 17, 2025
Comment on lines
153
to
154
| string using the helper method. Use the `byte` string representation when you are | ||
| indexing hash objects (as we are here), but use the array of `float` directly for |
There was a problem hiding this comment.
Suggested change
| string using the helper method. Use the `byte` string representation when you are | |
| indexing hash objects (as we are here), but use the array of `float` directly for | |
| string using the helper method. Use the `byte` string representation when indexing hash objects (as you're doing here), but use the array of `float` directly for |
|
|
||
| List<String> basicResults = jedis.vsim("famousPeople", actorsEmbedding); | ||
| System.out.println(basicResults); | ||
| // >>> [Masako Natsume, Chaim Topol, Linus Pauling, Marie Fredriksson, Maryam Mirzakhani, Marie Curie, Freddie Mercury, Paul Erdos] |
There was a problem hiding this comment.
This line is very long and produces a horizontal scroll bar in the rendered example.
|
|
||
| List<String> entertainerResults = jedis.vsim("famousPeople", entertainerEmbedding); | ||
| System.out.println(entertainerResults); | ||
| // >>> [Freddie Mercury, Chaim Topol, Linus Pauling, Marie Fredriksson, Masako Natsume, Paul Erdos, Maryam Mirzakhani, Marie Curie] |
There was a problem hiding this comment.
Horizontal scroll, as before.
|
@dwdougherty Suggestions applied (I thought I'd got rid of "we" everywhere in these, but apparently not). Thanks for the review :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jedis version of the vector sets embedding page.
BONUS FEATURE! The embedding model used in the old Jedis vector search example was dodgy and was not using the same embedding model as the other similar pages. This has now been fixed and the new vector sets page uses the same updated embedding model.