RS: Added rladmin commands to change node roles #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwdougherty
reviewed
Sep 17, 2025
| 1. On the **Nodes** screen, click the **More actions** button (**⋮**) for the primary node you want to demote. | ||
|
|
||
| {{<image filename="images/rs/screenshots/nodes/primary-node-more-actions.png" alt="Click the more actions button for a node to access node actions.">}} | ||
| <img src="../../../../images/rs/screenshots/nodes/primary-node-more-actions.png" alt="Click the more actions button for a node to access node actions."> |
There was a problem hiding this comment.
Just because I'm curious: why wouldn't you use the full path ( /images/rs/... ) instead of a relative path like above?
There was a problem hiding this comment.
@dwdougherty Thanks for reviewing!
I tried using something like <img src="/images/rs/... at first, but the images only rendered properly in my local env. When I checked the staged preview, the images were actually broken. It would try to use https://redis.io/images/rs/screenshots/... instead of the correct URL https://redis.io/docs/staging/DOC-####/images/rs/screenshots/....
There was a problem hiding this comment.
I should have know that you'd have tried the full path. 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cherry-picked the img fix/workaround that allows screenshots within the multitabs shortcode.