-
Notifications
You must be signed in to change notification settings - Fork 269
DOC-5849 added draft redis-py failover page #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language looks good to me.
|
|
||
| | Option | Description | | ||
| | --- | --- | | ||
| | `client_kwargs` | Keyword parameters to pass to the internal `RedisClient` constructor for this endpoint. Use it to specify the host, port, username, password, and other connection parameters (see [Connect to the server]({{< relref "/develop/clients/redis-py/connect" >}}) for more information). | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add here information how the different types of clients can be used - sync/async Redis and sync/async RedisCluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've expanded the description for this option, but I've also added a short section about using client_class to choose which client you want.
|
@cmilesb @petyaslavova Thanks for the reviews! |
Docs for the redis-py failover feature (there's a separate PR for Jedis failover; these are the only clients supporting the feature so far). At this draft stage, there's quite a bit of common content between both pages, especially in the description of failover concepts. We'll probably want to extract this out into a separate overview page when all the details of the feature are finalised.