DEV: clarify trimming threshold definitions in XTRIM and XADD #2509
+39
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the definition of the trimming threshold for MAXLEN and MINID, specifying that MAXLEN requires a non-negative integer.
Contributor
Updated syntax format and string for XTRIM command.
LiorKogan
changed the title
Clarified the descriptions for MAXLEN and MINID trimming strategies, emphasizing the behavior of Redis during the trimming process.
Clarify the explanation of trimming thresholds for MAXLEN and MINID in xadd.md.
Clarified the description of the 'MAXLEN' threshold in the xtrim command documentation.
Updated formatting for clarity in xtrim command documentation.
dwdougherty
changed the title
dwdougherty
approved these changes
Dec 4, 2025
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Thank you, @LiorKogan! Funny story: the automation we have in place to update data/commands_core.json isn't currently running, so that's why those options were missing in the syntax. Facepalm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the definition of the trimming threshold for MAXLEN and MINID, specifying that MAXLEN requires a non-negative integer.