Skip to content

K8s: delete RERC #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

K8s: delete RERC #661

wants to merge 5 commits into from

Conversation

@kaitlynmichael
Copy link
Contributor

@kaitlynmichael kaitlynmichael commented Sep 12, 2024 •
edited
Loading

@kaitlynmichael kaitlynmichael requested review from a team, almoggue and yuvallevy2 September 12, 2024 02:51
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-2620/operate/kubernetes/active-active/delete-rerc

andy-stark-redis
andy-stark-redis approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor glitch, but otherwise looks good :-)

@kaitlynmichael @andy-stark-redis
Apply suggestions from code review
930b0bd 
Co-authored-by: andy-stark-redis <[email protected]>
andy-stark-redis
andy-stark-redis approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitlynmichael kaitlynmichael self-assigned this Sep 24, 2024
@kaitlynmichael kaitlynmichael marked this pull request as draft September 30, 2024 15:01
@kaitlynmichael
Copy link
Contributor Author

Closing for now until dev and support decide on a course of action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy-stark-redis andy-stark-redis andy-stark-redis approved these changes

@yuvallevy2 yuvallevy2 Awaiting requested review from yuvallevy2

@almoggue almoggue Awaiting requested review from almoggue

Assignees

@kaitlynmichael kaitlynmichael

Labels

do not merge yet k8s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaitlynmichael @andy-stark-redis