Skip to content

Conversation

@mich-elle-luna
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

@mich-elle-luna mich-elle-luna marked this pull request as ready for review November 22, 2024 19:45
@mich-elle-luna mich-elle-luna requested a review from a team November 22, 2024 19:47
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues, but it's huge, so not entirely surprising :-) Great concept for a page, showing how to use a tool to actively locate problems along with advice on how to fix them.

mich-elle-luna and others added 18 commits December 2, 2024 15:39
mich-elle-luna and others added 22 commits December 2, 2024 15:46
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some issues with this but nothing major, so I'll approve.

There were several absolute links that needed replacing with relrefs, but it was quicker to just fix them in the editor and add a new commit rather than making suggestion comments for all of them.

I think this page would probably benefit from a bit more attention in the future, but it seems OK to be getting on with.


The new engine enables real-time monitoring, including full monitoring during maintenance operations, providing full visibility into performance during events such as shards' failovers and scaling operations. See [Monitoring with metrics and alerts]({{<relref "/operate/rs/clusters/monitoring/">}}) for more details.

If you are already using the existing scraping endpoint for integration, follow [this guide]({{<relref "/integrate/prometheus-with-redis-enterprise/prometheus-metrics-v1-to-v2">}}) to transition and try the new engine. You can scrape both existing and new endpoints simultaneously, which lets you create advanced dashboards and transition smoothly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generates a bad link but the file does actually exist in the main branch, so the final merge will fix it.

The Redis Enterprise database dashboard indicates the total number of connections to the database.

You should monitor this connection count metric with both a minimum and maximum number of connections in mind.
Based on the number of application instances connecting to Redis (and whether your application uses [connection pooling]({{< relref "/develop/clients/pools-and-muxing" >}})),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generates a bad link but I think this branch was started before I moved the clients folder up a level. It should work OK when you merge this branch with main.


| Issue | Remediation |
| ------ | :------ |
|The KEYS command shows up in the slow log |Find the application that issues the KEYS command and replace it with a SCAN command. In an emergency situation, you can [alter the ACLs for the database user](https://redis.io/docs/latest/operate/rs/security/access-control/rbac/configure-acl/) so that Redis will reject the KEYS command altogether. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't make a relref for this one because I couldn't find it. Don't know if it's moved or obsolete?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

3. Finally, run `redis-cli --hotkeys`

You may also identify hot keys by sampling the operations against Redis.
You can use do this by running the [MONITOR](https://redis.io/docs/latest/commands/monitor/) command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can use do this by running the [MONITOR](https://redis.io/docs/latest/commands/monitor/) command
You can do this by running the [MONITOR](https://redis.io/docs/latest/commands/monitor/) command

@mich-elle-luna mich-elle-luna merged commit 5e8e663 into main Dec 11, 2024
5 checks passed
@mich-elle-luna mich-elle-luna deleted the observability branch December 11, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants