- 
                Notifications
    
You must be signed in to change notification settings  - Fork 270
 
Create observability.md #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few issues, but it's huge, so not entirely surprising :-) Great concept for a page, showing how to use a tool to actively locate problems along with advice on how to fix them.
        
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some issues with this but nothing major, so I'll approve.
There were several absolute links that needed replacing with relrefs, but it was quicker to just fix them in the editor and add a new commit rather than making suggestion comments for all of them.
I think this page would probably benefit from a bit more attention in the future, but it seems OK to be getting on with.
| 
               | 
          ||
| The new engine enables real-time monitoring, including full monitoring during maintenance operations, providing full visibility into performance during events such as shards' failovers and scaling operations. See [Monitoring with metrics and alerts]({{<relref "/operate/rs/clusters/monitoring/">}}) for more details. | ||
| 
               | 
          ||
| If you are already using the existing scraping endpoint for integration, follow [this guide]({{<relref "/integrate/prometheus-with-redis-enterprise/prometheus-metrics-v1-to-v2">}}) to transition and try the new engine. You can scrape both existing and new endpoints simultaneously, which lets you create advanced dashboards and transition smoothly. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates a bad link but the file does actually exist in the main branch, so the final merge will fix it.
| The Redis Enterprise database dashboard indicates the total number of connections to the database. | ||
| 
               | 
          ||
| You should monitor this connection count metric with both a minimum and maximum number of connections in mind. | ||
| Based on the number of application instances connecting to Redis (and whether your application uses [connection pooling]({{< relref "/develop/clients/pools-and-muxing" >}})), | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generates a bad link but I think this branch was started before I moved the clients folder up a level. It should work OK when you merge this branch with main.
| 
               | 
          ||
| | Issue | Remediation | | ||
| | ------ | :------ | | ||
| |The KEYS command shows up in the slow log |Find the application that issues the KEYS command and replace it with a SCAN command. In an emergency situation, you can [alter the ACLs for the database user](https://redis.io/docs/latest/operate/rs/security/access-control/rbac/configure-acl/) so that Redis will reject the KEYS command altogether. | | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't make a relref for this one because I couldn't find it. Don't know if it's moved or obsolete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixed
        
          
                content/integrate/prometheus-with-redis-enterprise/observability.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 3. Finally, run `redis-cli --hotkeys` | ||
| 
               | 
          ||
| You may also identify hot keys by sampling the operations against Redis. | ||
| You can use do this by running the [MONITOR](https://redis.io/docs/latest/commands/monitor/) command | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You can use do this by running the [MONITOR](https://redis.io/docs/latest/commands/monitor/) command | |
| You can do this by running the [MONITOR](https://redis.io/docs/latest/commands/monitor/) command | 
…ty.md Co-authored-by: andy-stark-redis <[email protected]>
No description provided.