Skip to content

DOC-4519 fixed bugs in config folder diagram #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2024
Merged

DOC-4519 fixed bugs in config folder diagram #842

merged 2 commits into from
Nov 7, 2024

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Nov 5, 2024 •
edited by atlassian bot
Loading

@andy-stark-redis andy-stark-redis marked this pull request as ready for review November 5, 2024 11:08
@andy-stark-redis andy-stark-redis self-assigned this Nov 5, 2024
dwdougherty
dwdougherty approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick: all but one of the describing sentences ends in a period. Maybe the first should also? I'll leave it to you to decide.

@andy-stark-redis
Copy link
Contributor Author

One minor nitpick: all but one of the describing sentences ends in a period. Maybe the first should also? I'll leave it to you to decide.

Well spotted! Yes, you're absolutely right.

@andy-stark-redis andy-stark-redis merged commit e177282 into main Nov 7, 2024
4 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-4519-rdi-fix-folder-diagram branch November 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwdougherty dwdougherty dwdougherty approved these changes

@yaronp68 yaronp68 Awaiting requested review from yaronp68

Assignees

@andy-stark-redis andy-stark-redis

Labels

rdi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andy-stark-redis @dwdougherty