Skip to content

Conversation

@andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Nov 26, 2024

DOC-4597

There were also some other obsolete references to the installer creating the RDI DB automatically, which I've removed.

@andy-stark-redis andy-stark-redis added bug Something isn't working rdi labels Nov 26, 2024
@andy-stark-redis andy-stark-redis self-assigned this Nov 26, 2024
@andy-stark-redis andy-stark-redis marked this pull request as ready for review November 26, 2024 11:32
- Set the database's
[eviction policy]({{< relref "/operate/rs/databases/memory-performance/eviction-policy" >}}) to `noeviction` and set
[data persistence]({{< relref "/operate/rs/databases/configure/database-persistence" >}})
to AOF - fsync every 1 sec.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be also surrounded with backticks, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spicy-sauce You can set these from the Cluster manager UI as well as the CLI. The linked pages give more explanation, so I was trying to follow the existing formatting (for example, this table). The eviction policies are listed using the key name, which is why I used backticks for that.

However, if you think backticks for all of these would be clearer then I'll be happy to add them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I suggest to follow the guidelines you have in other documents in RDI and in general.

Comment on lines 23 to 24
{{< note >}}We recommend you use RDI v1.4.0 or above. The previous version, RDI v1.2.8,
will not work on VMs where IPv6 is disabled. This problem is solved with version 1.4.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we recommend to install 1.4.2 and not older versions... @yaronp68 WDYT?

- Set the database's
[eviction policy]({{< relref "/operate/rs/databases/memory-performance/eviction-policy" >}}) to `noeviction` and set
[data persistence]({{< relref "/operate/rs/databases/configure/database-persistence" >}})
to AOF - fsync every 1 sec.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backticks?

- Set the database's
[eviction policy]({{< relref "/operate/rs/databases/memory-performance/eviction-policy" >}}) to `noeviction` and set
[data persistence]({{< relref "/operate/rs/databases/configure/database-persistence" >}})
to AOF - fsync every 1 sec.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backticks?

Comment on lines +59 to +65
- A single-shard database with 125MB RAM is enough for the quickstart but double this
to 250MB if you want to add a replica.
- Provide the installation with the required RDI database details.
- Set the database's
[eviction policy]({{< relref "/operate/rs/databases/memory-performance/eviction-policy" >}}) to `noeviction` and set
[data persistence]({{< relref "/operate/rs/databases/configure/database-persistence" >}})
to AOF - fsync every 1 sec.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we share this somehow? we have it in a several places in our docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spicy-sauce I was wondering about this myself, but it might be a bit short to have a page of its own and also the info in the quickstart is slightly different from the two install pages (ie, you probably wouldn't need the replica for the quickstart).

@andy-stark-redis andy-stark-redis merged commit f6c2ea1 into main Nov 28, 2024
5 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-4597-rdi-install-updates branch November 28, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rdi

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants