JSON.MGET - clarify behavior when the specified keys are in different shards #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dwdougherty
reviewed
Dec 4, 2024
dwdougherty
requested changes
Dec 4, 2024
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Just a few tweaks are necessary.
Co-authored-by: David Dougherty <[email protected]>
oranagra
reviewed
Dec 5, 2024
content/commands/json.mget/index.md
Outdated
| {{% warning %}} | ||
| When cluster mode is enabled, all specified keys must reside on the same [hash slot](https://redis.io/docs/latest/operate/oss_and_stack/reference/cluster-spec/#key-distribution-model). | ||
|
|
||
| When the database has more than one shard, and the specified keys reside in different shards, Redis will not report a CROSSSLOT error, and the results may be partial. |
Member
There was a problem hiding this comment.
maybe give some saddle hint as to why and what's expected in the future?
Member
Author
There was a problem hiding this comment.
@oranagra nothing for the short term. For the longer term see "How can we address this issue for the long term?" in https://redislabs.atlassian.net/browse/MOD-7315
Member
There was a problem hiding this comment.
i understand.. just suggesting that we add some hint in the text about that.
so users will have a clue that it was not intended, instead of asking why is it.
dwdougherty
approved these changes
Dec 5, 2024
Collaborator
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
LGTM, @LiorKogan. Does @oranagra need to review one more time, or can I merge this PR?
Member
Author
|
@dwdougherty please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.