withTimeout create NewConnPool #2655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndyakov
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
@taytzehao initially i was thinking this makes sense, but after more investigation I am wondering if this was not by design. Needs deeper investigation.
|
Well @taytzehao I do think this is by design to reuse the same pool, don't you think? Closing this PR, but feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new Connection pool for the cloned client. The copy performed by the
clone := *coperation is just a shallow copy. This causes the ConnPool in the clone to be referring to the ConnPool in the old Client. When a new hook is added to the client, the hook is added to the newly cloned hook rather than the old one.Added unit test case.
#2561