feat: add connection waiting statistics #2804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzakharov
force-pushed
the
add-conn-pool-wait-stats
branch
2 times, most recently
from
97ce6b9 to
588a71f
Compare
|
Tests fixed in #2808. |
|
@ofekshenawa sorry for disturbing, can you review please? This PR can help a lot. Thanks in advance! |
|
Hey @lzakharov, sorry for the delay:) |
lzakharov
force-pushed
the
add-conn-pool-wait-stats
branch
from
f9b11c5 to
ee7a48e
Compare
|
@ofekshenawa hi!) Conflicts are resolved. |
ofekshenawa
approved these changes
Apr 30, 2025
|
I see that Are they expected to be populated there? |
ofekshenawa
added a commit
to ofekshenawa/go-redis
that referenced
this pull request
Jun 30, 2025
Co-authored-by: ofekshenawa <[email protected]>
ofekshenawa
added a commit
that referenced
this pull request
Aug 10, 2025
Co-authored-by: ofekshenawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds connection waiting statistics. These statistics are useful for tuning pool parameters. Inspired by redigo stats.
I removed doctests with Go 1.18 due to
atomic.Int64usage.