fix: race slice for list function of ring client #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ndyakov merged 7 commits into redis:master from rfyiamcool:fix/race_slice_ring_client

Feb 20, 2025

ring.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -341,7 +341,8 @@ func (c *ringSharding) List() []*ringShard { @@
     	c.mu.RLock()
     	if !c.closed {
-    		list = c.shards.list
+    		list = make([]*ringShard, len(c.shards.list))
+    		copy(c.shards.list, list)
     	}
     	c.mu.RUnlock()
@@ Expand Down @@