Skip to content

fix the maxActiveConns sematic #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix the maxActiveConns sematic #2934

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4373801
fix: fix the maxActiveConns sematic
lawlielt Mar 5, 2024
960b7a3
Merge pull request #1 from lawlielt/lawlielt-patch-1
lawlielt Mar 5, 2024
ef869a5
Merge branch 'master' into master
ofekshenawa Mar 6, 2024
f3cc252
Merge branch 'master' into master
ofekshenawa Mar 21, 2024
113031f
Merge branch 'master' into master
ndyakov Feb 4, 2025
99a09c6
Merge branch 'master' into master
ndyakov Jun 5, 2025
4794ada
Merge branch 'master' into master
ndyakov Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/pool/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (p *ConnPool) newConn(ctx context.Context, pooled bool) (*Conn, error) {
}

p.connsMu.Lock()
if p.cfg.MaxActiveConns > 0 && p.poolSize >= p.cfg.MaxActiveConns {
if p.cfg.MaxActiveConns > 0 && len(p.conns) >= p.cfg.MaxActiveConns {
p.connsMu.Unlock()
return nil, ErrPoolExhausted
}
Expand All @@ -183,7 +183,7 @@ func (p *ConnPool) newConn(ctx context.Context, pooled bool) (*Conn, error) {
p.connsMu.Lock()
defer p.connsMu.Unlock()

if p.cfg.MaxActiveConns > 0 && p.poolSize >= p.cfg.MaxActiveConns {
if p.cfg.MaxActiveConns > 0 && len(p.conns) >= p.cfg.MaxActiveConns {
_ = cn.Close()
return nil, ErrPoolExhausted
}
Expand Down