feat: add command name to metrics #3050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmihailenco reviewers? |
wzy9607
reviewed
Sep 15, 2024
| attrs = append(attrs, mh.attrs...) | ||
| attrs = append(attrs, attribute.String("type", "command")) | ||
| attrs = append(attrs, statusAttr(err)) | ||
| attrs = append(attrs, attribute.String("cmd", cmd.FullName())) |
There was a problem hiding this comment.
should use db.operation semconv.DBOperation attribute in semconv v1.24, or db.operation.name semconv.DBOperationName attribute in semconv v1.26,
instead of custom attribute cmd.
|
@monkey92t let's work on reviewing this one. |
|
This doesn’t seem like a very good solution. Although there are only a few hundred Redis commands, whether it will impact OpenTelemetry requires investigation and testing. |
|
closing for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2872