-
Notifications
You must be signed in to change notification settings - Fork 2.5k
added Do
method for raw query by single conn from pool.Conn()
#3182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
db2321c
added `Do` method for raw query by single conn from `pool.Conn()`
48f16d8
added test to cmdble Do method
ce5468a
Merge branch 'master' into do_cmd_for_simple_conn
ndyakov 6cf3abc
fixed test
22df81e
Merge remote-tracking branch 'origin/do_cmd_for_simple_conn' into do_…
3616f65
Merge branch 'master' into do_cmd_for_simple_conn
oleglacto e301dad
Merge branch 'master' into do_cmd_for_simple_conn
ndyakov 6e5adac
moved Do cmd to commands.go
c201e02
Merge branch 'master' into do_cmd_for_simple_conn
ndyakov b537f7c
Merge branch 'master' into do_cmd_for_simple_conn
ndyakov dd8d920
Merge branch 'master' into do_cmd_for_simple_conn
ndyakov c25ee1e
Merge branch 'master' into do_cmd_for_simple_conn
ndyakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package redis | ||
|
||
import "context" | ||
|
||
func (c cmdable) Do(ctx context.Context, args ...interface{}) *Cmd { | ||
cmd := NewCmd(ctx, args) | ||
_ = c(ctx, cmd) | ||
return cmd | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package redis_test | ||
|
||
import ( | ||
. "github.com/bsm/ginkgo/v2" | ||
. "github.com/bsm/gomega" | ||
|
||
"github.com/redis/go-redis/v9" | ||
) | ||
|
||
var _ = Describe("Do cmdble", func() { | ||
var client *redis.Client | ||
|
||
BeforeEach(func() { | ||
client = redis.NewClient(redisOptions()) | ||
Expect(client.FlushDB(ctx).Err()).NotTo(HaveOccurred()) | ||
}) | ||
|
||
AfterEach(func() { | ||
client.Close() | ||
}) | ||
|
||
It("should pong with Do cmd", func() { | ||
result := client.Conn().Do(ctx, "PING") | ||
Expect(result.Result()).To(Equal("PONG")) | ||
Expect(result.Err()).NotTo(HaveOccurred()) | ||
}) | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.