[ISSUE-3402]: Ring.Pipelined return dial timeout error #3403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smnvdev thank you for your contribution, I hope @monkey92t or @vmihailenco can review this, If not we will review it when possible, but Ring is not our main priority at the moment, just letting you know. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the dial timeout error issue for the Ring.Pipelined method by adding a new test case and adjusting the pipeline processing logic.
- Adds a test in ring_test.go to ensure a dial timeout error is returned when an invalid address is provided with a low dial timeout.
- Modifies the pipeline processing in ring.go to correctly handle transactional pipelines using a distinct hook assignment.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ring_test.go | New test case to check dial timeout errors in the pipeline function. |
| ring.go | Updates to pipeline processing including refined hook assignment. |
Comments suppressed due to low confidence (1)
ring_test.go:293
- [nitpick] Consider enhancing the test by asserting that the error is specifically a dial timeout error rather than any error, to ensure the test accurately verifies the intended behavior.
Expect(err).To(HaveOccurred())
ndyakov
previously approved these changes
Jun 26, 2025
ndyakov
approved these changes
Jul 2, 2025
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
* [ISSUE-3402]: Ring.Pipelined return dial timeout error * review fixes --------- Co-authored-by: Nedyalko Dyakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3402