Skip to content

Ignore not indexded objects #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ignore not indexded objects #3430

wants to merge 1 commit into from

Conversation

byzmonk
Copy link

@byzmonk byzmonk commented Jul 14, 2025

No description provided.

ndyakov
ndyakov requested changes Jul 15, 2025
View reviewed changes
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @byzmonk , thank you for your contriution! Please add description what this is fixing and address the PR comment.

search_commands.go
fields, ok := data[i].([]interface{})
if !ok {
return FTSearchResult{}, fmt.Errorf("invalid field key format")
fmt.Println(data[i])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this debug output

@ndyakov
Copy link
Member

ndyakov commented Aug 4, 2025

This should be now fixed. Indexed but missing object will return Error = proto.Nil and an empty map of fields.

@ndyakov ndyakov closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndyakov ndyakov ndyakov requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@byzmonk @ndyakov