Skip to content

fix: Prioritize TextMarshaler for argument serialization (#3139) #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Prioritize TextMarshaler for argument serialization (#3139) #3445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3498462
fix: Prioritize TextMarshaler for argument serialization (#3139)
ostheperson Jul 24, 2025
8d867ff
fix: Prioritize TextMarshaler for argument serialization (#3139)
ostheperson Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/proto/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,20 @@ func (w *Writer) WriteArg(v interface{}) error {
return w.int(0)
}
return w.int(v.Nanoseconds())
case net.IP:
return w.bytes(v)
case encoding.TextMarshaler:
b, err := v.MarshalText()
if err != nil {
return err
}
return w.bytes(b)
case encoding.BinaryMarshaler:
b, err := v.MarshalBinary()
if err != nil {
return err
}
return w.bytes(b)
case net.IP:
return w.bytes(v)
default:
return fmt.Errorf(
"redis: can't marshal %T (implement encoding.BinaryMarshaler)", v)
Expand Down
Loading