chore: update & fix otel example #3466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vmihailenco, glad to see you back opening a PR. Could you please add more description in the PR to what this fixes and what the additions are. Thank you! |
|
@ndyakov basically I've just upgraded the example to use Uptrace v2 we've recently released. It comes with a new config formatting so it might look scary, but it is just a copy/paste of the default config. Also updated README with new instructions and screenshots. Is there anything in particular that concerns you? |
|
@vmihailenco not necessarily, I just want to add a bit of context for the commit that will be merged in master. Than you, will add this information as part of the commit message. |
Uptrace v2 comes with a new config file and new defaults. Also updated dependencies to the latest versions.
vmihailenco
force-pushed
the
chore/update-otel-example
branch
from
e9bf81b to
c7a01e7
Compare
|
@ndyakov PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example to use Uptrace v2 that was recently released. It comes with a new config formatting.
Also updated README with new instructions and screenshots.