-
Notifications
You must be signed in to change notification settings - Fork 3.9k
docs: Improve Javadoc for HostAndPortMapper (#4112) #4227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve Javadoc for HostAndPortMapper (#4112) #4227
Conversation
Deprecation goes for "Release Notes" section itself. My idea is to use the wiki as a dev-friendly doc with more code examples. PS: @JuneYub forgot to say, Hi and thanks for the involvement! |
Hello, thank you for the review. |
@JuneYub You can take a look at docs/README.md how to generate docs locally, then advanced-usage should be available at http://0.0.0.0:8000/advanced-usage/ Hope it helps... |
Hi @ggivo, Thanks for the feedback! I have added the documentation for To help users better understand its usage, I've included examples for both implementing it with a dedicated class and using a more concise lambda expression, especially since it's a functional interface. Please take a look when you have a moment. I'm open to any further suggestions. Thanks! |
@JuneYub However, as part of our ongoing effort to simplify the API, we’re aiming to reduce the number of public constructors and promote the single constructor that accepts a |
@ggivo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation for the HostAndPortMapper
interface as requested in issue #4112. The changes focus on enhancing code-level documentation since the wiki is deprecated.
- Added comprehensive Javadoc comments to the
HostAndPortMapper
interface - Added detailed documentation section in advanced-usage.md explaining the purpose and usage of
HostAndPortMapper
- Provided practical examples showing both class-based and lambda-based implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/main/java/redis/clients/jedis/HostAndPortMapper.java | Added interface-level Javadoc and method documentation with @FunctionalInterface annotation |
docs/advanced-usage.md | Added comprehensive documentation section with examples for NAT/containerization scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@JuneYub |
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.1.0` -> `6.2.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.98.1` -> `6.99.0` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.2.0`](https://github.com/redis/jedis/releases/tag/v6.2.0): 6.2.0 ### Changes #### 🚀 New Features - \[vector sets] Support for VSIM WITHATTRIBS (CAE-1421) ([#​4260](redis/jedis#4260)) - Support Redis 8 vector sets [#​4169](redis/jedis#4169) ([#​4203](redis/jedis#4203)) #### 🐛 Bug Fixes - Fix JedisBroadcastException in functionLoadReplace for Redis Cluster ([#​4219](redis/jedis#4219)) #### 🧰 Maintenance - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.2 to 3.11.3 ([#​4246](redis/jedis#4246)) - Bump org.junit:junit-bom from 5.13.3 to 5.13.4 ([#​4216](redis/jedis#4216)) - docs: Improve Javadoc for HostAndPortMapper ([#​4112](redis/jedis#4112)) ([#​4227](redis/jedis#4227)) #### Contributors We'd like to thank all the contributors who worked on this release! [@​JuneYub](https://github.com/JuneYub), [@​Kguswo](https://github.com/Kguswo), [@​dependabot](https://github.com/dependabot), [@​dependabot](https://github.com/dependabot)\[bot] and [@​ggivo](https://github.com/ggivo) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.99.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6990-2025-08-26) ##### Features - Support read lock mode for R/W transactions ([#​4010](googleapis/java-spanner#4010)) ([7d752d6](googleapis/java-spanner@7d752d6)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.62.0 ([52c68db](googleapis/java-spanner@52c68db)) - GetCommitResponse() should return error if tx has not committed ([#​4021](googleapis/java-spanner#4021)) ([a2c179f](googleapis/java-spanner@a2c179f)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.52.0 ([#​4024](googleapis/java-spanner#4024)) ([7e3294f](googleapis/java-spanner@7e3294f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9d031eaaab2d726402884bd41681c856931f12f0
Improves Javadoc as requested in #4112.
The wiki is deprecated, so I've focused on the code-level documentation.
Closes #4112