-
Notifications
You must be signed in to change notification settings - Fork 2
Add check for missing IdentityProvider configuration. #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggivo this makes sense. thanks for dealing with that..
how about failing checks,, are they related ?
right,, this is due to missing secrets in forks. about spellcheck, looks like i didnt pay enough attention to that in #10
to wordlist ?? or i could. |
i ll come up with a plan for missing secrets later. |
Will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
It can happen that client ID/secret are not set for some reason (e.g read from env variables but because of misconfiguration null values are used). In such case, identityProviderConfig will remain null and generate NPE when later used.
Introducing an additional check that at least one of the expected configuration settings is applied before invoking build()