Switch to revelc formatter and format code

[atakavci]

No description provided.

[tishun]

LGTM

[ggivo]

Regarding formatting, I think we should consider using a more recent version of hbase_formatter.xml. Current is versioned 12 from 2019, and later is from 2022 versioned 22. Should support some more up to date IDE settings, but basically the same.

https://github.com/apache/hbase/commits/master/dev-support/hbase_eclipse_formatter.xml

<profiles version="22">
    <profile kind="CodeFormatterProfile" name="'HBase Apache Current'" version="22">

[atakavci]

hey @ggivo , did you experience this version 22 on any code base ??
asking this because though i tried to re-apply a couple of fixes that i did on version 12, i got things like below with version 22.

    public IAuthenticationResult requestWithConfidentialClient(ConfidentialClientApplication app,
        ClientCredentialParameters params) {
        try {
           ...

    public void testTokenManagerWithHangingTokenRequest()
        throws InterruptedException, ExecutionException, TimeoutException {
        int delayDuration = 200;
        ...

you see line 2 and line 3 are aligned in these, which i dont like.

[atakavci]

besides with a quick look seeing something like this parentheses_positions_in_method_delcaration in source, kind of emitting bad signals in terms of review&test.

[ggivo]

hey @ggivo , did you experience this version 22 on any code base ?? asking this because though i tried to re-apply a couple of fixes that i did on version 12, i got things like below with version 22.

No, I have not yet. I just saw that it is the version used on the HBase code base. I was going to experiment with it for Jedis formatting.

[atakavci]

i think i will go merge this PR with old version of hbase if you feel comfortable. This repo is less of a subject to discuss on formatting, relative to Jedis.