resp3 tests

Author: nkaradzhov

packages/client/lib/commands/VADD.spec.ts

@@ -14,7 +14,7 @@ describe('VADD', () => {
 
     it('with REDUCE option', () => {
       assert.deepEqual(
-        parseArgs(VADD, 'key', [1.0, 2.0], 'element', { REDUCE: 50 }),
+        parseArgs(VADD, 'key', [1.0, 2], 'element', { REDUCE: 50 }),
         ['VADD', 'key', 'REDUCE', '50', 'VALUES', '2', '1', '2', 'element']
       );
     });
@@ -63,4 +63,33 @@ describe('VADD', () => {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
+
+  testUtils.testWithClient('vAdd with RESP3', async client => {
+    // Test basic functionality with RESP3
+    assert.equal(
+      await client.vAdd('resp3-key', [1.5, 2.5, 3.5], 'resp3-element'),
+      true
+    );
+
+    // Test with options to ensure complex parameters work with RESP3
+    assert.equal(
+      await client.vAdd('resp3-key', [4.0, 5.0, 6.0], 'resp3-element2', {
+        QUANT: 'Q8',
+        CAS: true,
+        SETATTR: { type: 'test', value: 123 }
+      }),
+      true
+    );
+
+    // Verify the vector set was created correctly
+    assert.equal(
+      await client.vCard('resp3-key'),
+      2
+    );
+  }, {
+    ...GLOBAL.SERVERS.OPEN,
+    clientOptions: {
+      RESP: 3
+    }
+  });
 });

packages/client/lib/commands/VADD.ts

@@ -1,5 +1,5 @@
 import { CommandParser } from '../client/parser';
-import { RedisArgument, NumberReply, Command } from '../RESP/types';
+import { RedisArgument, NumberReply, Command, BooleanReply } from '../RESP/types';
 import { transformDoubleArgument } from './generic-transformers';
 
 export interface VAddOptions {
@@ -61,5 +61,8 @@ export default {
       parser.push('M', options.M.toString());
     }
   },
-  transformReply: undefined as unknown as () => NumberReply
+  transformReply: {
+    2: undefined as unknown as () => NumberReply,
+    3: undefined as unknown as () => BooleanReply
+  }
 } as const satisfies Command;

packages/client/lib/commands/VCARD.spec.ts

@@ -23,4 +23,31 @@ describe('VCARD', () => {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
+
+  testUtils.testWithClient('vCard with RESP3', async client => {
+    // Test empty vector set
+    assert.equal(
+      await client.vCard('resp3-empty-key'),
+      0
+    );
+
+    // Add elements and test cardinality
+    await client.vAdd('resp3-key', [1.0, 2.0], 'elem1');
+    assert.equal(
+      await client.vCard('resp3-key'),
+      1
+    );
+
+    await client.vAdd('resp3-key', [3.0, 4.0], 'elem2');
+    await client.vAdd('resp3-key', [5.0, 6.0], 'elem3');
+    assert.equal(
+      await client.vCard('resp3-key'),
+      3
+    );
+  }, {
+    ...GLOBAL.SERVERS.OPEN,
+    clientOptions: {
+      RESP: 3
+    }
+  });
 });

packages/client/lib/commands/VDIM.spec.ts

@@ -22,4 +22,31 @@ describe('VDIM', () => {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
+
+  testUtils.testWithClient('vDim with RESP3', async client => {
+    // Test with different vector dimensions
+    await client.vAdd('resp3-2d', [1.0, 2.0], 'elem2d');
+    assert.equal(
+      await client.vDim('resp3-2d'),
+      2
+    );
+
+    await client.vAdd('resp3-5d', [1.0, 2.0, 3.0, 4.0, 5.0], 'elem5d');
+    assert.equal(
+      await client.vDim('resp3-5d'),
+      5
+    );
+
+    // Verify dimension consistency within the same vector set
+    await client.vAdd('resp3-5d', [6.0, 7.0, 8.0, 9.0, 10.0], 'elem5d-2');
+    assert.equal(
+      await client.vDim('resp3-5d'),
+      5
+    );
+  }, {
+    ...GLOBAL.SERVERS.OPEN,
+    clientOptions: {
+      RESP: 3
+    }
+  });
 });

packages/client/lib/commands/VEMB.spec.ts

@@ -21,4 +21,30 @@ describe('VEMB', () => {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
+
+  testUtils.testWithClient('vEmb with RESP3', async client => {
+    // Test retrieving embeddings with RESP3
+    const originalVector = [1.5, 2.5, 3.5, 4.5];
+    await client.vAdd('resp3-key', originalVector, 'resp3-element');
+
+    const embedding = await client.vEmb('resp3-key', 'resp3-element');
+    assert.ok(Array.isArray(embedding));
+    assert.equal(embedding.length, 4);
+
+    // Verify that all values are numbers (RESP3 should preserve numeric types)
+    embedding.forEach(value => {
+      assert.equal(typeof value, 'number');
+    });
+
+    // Test with quantized vector to ensure RESP3 handles different precision
+    await client.vAdd('resp3-key', [10.0, 20.0, 30.0, 40.0], 'quantized-elem', { QUANT: 'Q8' });
+    const quantizedEmbedding = await client.vEmb('resp3-key', 'quantized-elem');
+    assert.ok(Array.isArray(quantizedEmbedding));
+    assert.equal(quantizedEmbedding.length, 4);
+  }, {
+    ...GLOBAL.SERVERS.OPEN,
+    clientOptions: {
+      RESP: 3
+    }
+  });
 });

packages/client/lib/commands/VGETATTR.spec.ts

@@ -21,4 +21,38 @@ describe('VGETATTR', () => {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
+
+  testUtils.testWithClient('vGetAttr with RESP3', async client => {
+    // Test getting attributes with RESP3
+    await client.vAdd('resp3-key', [1.0, 2.0], 'resp3-element');
+
+    // Test null case (no attributes set)
+    const nullResult = await client.vGetAttr('resp3-key', 'resp3-element');
+    assert.equal(nullResult, null);
+
+    // Set complex attributes and retrieve them
+    const complexAttrs = {
+      name: 'test-item',
+      category: 'electronics',
+      price: 99.99,
+      inStock: true,
+      tags: ['new', 'featured']
+    };
+    await client.vSetAttr('resp3-key', 'resp3-element', complexAttrs);
+
+    const result = await client.vGetAttr('resp3-key', 'resp3-element');
+    assert.ok(result !== null);
+
+    // Parse the JSON result and verify structure
+    const parsedAttrs = JSON.parse(result.toString());
+    assert.equal(parsedAttrs.name, 'test-item');
+    assert.equal(parsedAttrs.price, 99.99);
+    assert.equal(parsedAttrs.inStock, true);
+    assert.ok(Array.isArray(parsedAttrs.tags));
+  }, {
+    ...GLOBAL.SERVERS.OPEN,
+    clientOptions: {
+      RESP: 3
+    }
+  });
 });