fix some tests

Author: nkaradzhov

packages/client/lib/commands/VADD.spec.ts

@@ -57,8 +57,15 @@ describe('VADD', () => {
   testUtils.testAll('vAdd', async client => {
     assert.equal(
       await client.vAdd('key', [1.0, 2.0, 3.0], 'element'),
-      1
+      true
+    );
+
+    // same element should not be added again
+    assert.equal(
+      await client.vAdd('key', [1, 2 , 3], 'element'),
+      false
     );
+
   }, {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
@@ -71,6 +78,12 @@ describe('VADD', () => {
       true
     );
 
+    // same element should not be added again
+    assert.equal(
+      await client.vAdd('resp3-key', [1, 2 , 3], 'resp3-element'),
+      false
+    );
+
     // Test with options to ensure complex parameters work with RESP3
     assert.equal(
       await client.vAdd('resp3-key', [4.0, 5.0, 6.0], 'resp3-element2', {

packages/client/lib/commands/VADD.ts

@@ -1,6 +1,6 @@
 import { CommandParser } from '../client/parser';
 import { RedisArgument, NumberReply, Command, BooleanReply } from '../RESP/types';
-import { transformDoubleArgument } from './generic-transformers';
+import { transformBooleanReply, transformDoubleArgument } from './generic-transformers';
 
 export interface VAddOptions {
   REDUCE?: number;
@@ -61,8 +61,5 @@ export default {
       parser.push('M', options.M.toString());
     }
   },
-  transformReply: {
-    2: undefined as unknown as () => NumberReply,
-    3: undefined as unknown as () => BooleanReply
-  }
+  transformReply: transformBooleanReply
 } as const satisfies Command;

packages/client/lib/commands/VCARD.spec.ts

@@ -19,6 +19,8 @@ describe('VCARD', () => {
       await client.vCard('key'),
       2
     );
+
+    assert.equal(await client.vCard('unknown'), 0);
   }, {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
@@ -44,6 +46,8 @@ describe('VCARD', () => {
       await client.vCard('resp3-key'),
       3
     );
+
+    assert.equal(await client.vCard('unknown'), 0);
   }, {
     ...GLOBAL.SERVERS.OPEN,
     clientOptions: {

packages/client/lib/commands/VCARD.ts

@@ -2,7 +2,6 @@ import { CommandParser } from '../client/parser';
 import { RedisArgument, NumberReply, Command } from '../RESP/types';
 
 export default {
-  CACHEABLE: true,
   IS_READ_ONLY: true,
   /**
    * Retrieve the number of elements in a vector set

packages/client/lib/commands/VDIM.spec.ts

@@ -24,25 +24,13 @@ describe('VDIM', () => {
   });
 
   testUtils.testWithClient('vDim with RESP3', async client => {
-    // Test with different vector dimensions
-    await client.vAdd('resp3-2d', [1.0, 2.0], 'elem2d');
-    assert.equal(
-      await client.vDim('resp3-2d'),
-      2
-    );
-
     await client.vAdd('resp3-5d', [1.0, 2.0, 3.0, 4.0, 5.0], 'elem5d');
-    assert.equal(
-      await client.vDim('resp3-5d'),
-      5
-    );
 
-    // Verify dimension consistency within the same vector set
-    await client.vAdd('resp3-5d', [6.0, 7.0, 8.0, 9.0, 10.0], 'elem5d-2');
     assert.equal(
       await client.vDim('resp3-5d'),
       5
     );
+
   }, {
     ...GLOBAL.SERVERS.OPEN,
     clientOptions: {

packages/client/lib/commands/VEMB.spec.ts

@@ -17,30 +17,19 @@ describe('VEMB', () => {
     const result = await client.vEmb('key', 'element');
     assert.ok(Array.isArray(result));
     assert.equal(result.length, 3);
+    assert.equal(typeof result[0], 'number');
   }, {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
 
   testUtils.testWithClient('vEmb with RESP3', async client => {
-    // Test retrieving embeddings with RESP3
-    const originalVector = [1.5, 2.5, 3.5, 4.5];
-    await client.vAdd('resp3-key', originalVector, 'resp3-element');
+    await client.vAdd('resp3-key', [1.5, 2.5, 3.5, 4.5], 'resp3-element');
 
-    const embedding = await client.vEmb('resp3-key', 'resp3-element');
-    assert.ok(Array.isArray(embedding));
-    assert.equal(embedding.length, 4);
-
-    // Verify that all values are numbers (RESP3 should preserve numeric types)
-    embedding.forEach(value => {
-      assert.equal(typeof value, 'number');
-    });
-
-    // Test with quantized vector to ensure RESP3 handles different precision
-    await client.vAdd('resp3-key', [10.0, 20.0, 30.0, 40.0], 'quantized-elem', { QUANT: 'Q8' });
-    const quantizedEmbedding = await client.vEmb('resp3-key', 'quantized-elem');
-    assert.ok(Array.isArray(quantizedEmbedding));
-    assert.equal(quantizedEmbedding.length, 4);
+    const result = await client.vEmb('resp3-key', 'resp3-element');
+    assert.ok(Array.isArray(result));
+    assert.equal(result.length, 4);
+    assert.equal(typeof result[0], 'number');
   }, {
     ...GLOBAL.SERVERS.OPEN,
     clientOptions: {

packages/client/lib/commands/VEMB.ts

@@ -1,5 +1,6 @@
 import { CommandParser } from '../client/parser';
-import { RedisArgument, ArrayReply, DoubleReply, Command } from '../RESP/types';
+import { RedisArgument, Command } from '../RESP/types';
+import { transformDoubleArrayReply } from './generic-transformers';
 
 export default {
   CACHEABLE: true,
@@ -17,5 +18,5 @@ export default {
     parser.pushKey(key);
     parser.push(element);
   },
-  transformReply: undefined as unknown as () => ArrayReply<DoubleReply>
+  transformReply: transformDoubleArrayReply
 } as const satisfies Command;

packages/client/lib/commands/VGETATTR.spec.ts

@@ -13,21 +13,26 @@ describe('VGETATTR', () => {
 
   testUtils.testAll('vGetAttr', async client => {
     await client.vAdd('key', [1.0, 2.0, 3.0], 'element');
+
+    const nullResult = await client.vGetAttr('key', 'element');
+    assert.equal(nullResult, null);
+
     await client.vSetAttr('key', 'element', { name: 'test' });
 
     const result = await client.vGetAttr('key', 'element');
     assert.ok(result !== null);
+
   }, {
     client: GLOBAL.SERVERS.OPEN,
     cluster: GLOBAL.CLUSTERS.OPEN
   });
 
   testUtils.testWithClient('vGetAttr with RESP3', async client => {
-    // Test getting attributes with RESP3
     await client.vAdd('resp3-key', [1.0, 2.0], 'resp3-element');
 
     // Test null case (no attributes set)
     const nullResult = await client.vGetAttr('resp3-key', 'resp3-element');
+
     assert.equal(nullResult, null);
 
     // Set complex attributes and retrieve them
@@ -41,6 +46,7 @@ describe('VGETATTR', () => {
     await client.vSetAttr('resp3-key', 'resp3-element', complexAttrs);
 
     const result = await client.vGetAttr('resp3-key', 'resp3-element');
+
     assert.ok(result !== null);
 
     // Parse the JSON result and verify structure