Skip to content

Conversation

htemelski
Copy link

@htemelski htemelski commented Mar 21, 2025

Description

Fixed a couple of issues with the sentinel implementation

  1. Indefinite reconnects without taking into consideration maxCommandRediscovers
  2. Client losing it's watch status if there are multiple topology changes during a transaction
  3. Fixed sentinel client .withTypeMapping() method

Fixed an issue with the testing setup itself, using the new docker image and setting the requirepass and masterauth configuration settings in a persistent way.

Enabled the majority of sentinel tests, added new test for fix 1.
Still skipping some tests that are flaky and prone to failing


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@htemelski htemelski merged commit 10ff6de into master Apr 30, 2025
11 checks passed
@htemelski htemelski deleted the cae-342 branch April 30, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants