Skip to content

Conversation

dhensby
Copy link
Contributor

@dhensby dhensby commented Mar 28, 2025

Description

Minor update to the @redis/entraid package to include a more efficient way to create the default credential, as well as updating the current version of the library that needs to be used.


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?


// Create a DefaultAzureCredential instance
const credential = new DefaultAzureCredential();
const credential = new getDefaultAzureCredential();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to remove ‘new’ ;
Have you tested the snippet? What is the difference between using constructor and ‘getDefaultAzureCredential’ ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, yes. I'll update this when I'm back at my computer

@dhensby dhensby force-pushed the pulls/entra-docs branch from f0f7428 to bb39631 Compare April 4, 2025 08:06
@dhensby dhensby requested a review from bobymicroby April 4, 2025 08:06
@bobymicroby bobymicroby merged commit 4d659f0 into redis:master Apr 7, 2025
2 checks passed
@dhensby dhensby deleted the pulls/entra-docs branch April 7, 2025 12:56
florian-schunk pushed a commit to florian-schunk/node-redis that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants