Skip to content

chore(tests): bump test container version 8.2 #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
fail-fast: false
matrix:
node-version: ["18", "20", "22"]
redis-version: ["rs-7.4.0-v1", "8.0.2", "8.2-rc2-pre"]
redis-version: ["rs-7.4.0-v1", "8.0.2", "8.2"]
steps:
- uses: actions/checkout@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ Node Redis v5 adds support for [Client Side Caching](https://redis.io/docs/manua
```typescript
// Enable client side caching with RESP3
const client = createClient({
RESP: 3,
RESP: 3,
clientSideCache: {
ttl: 0, // Time-to-live (0 = no expiration)
maxEntries: 0, // Maximum entries (0 = unlimited)
Expand Down Expand Up @@ -304,6 +304,7 @@ Node Redis is supported with the following versions of Redis:

| Version | Supported |
| ------- | ------------------ |
| 8.2.z | :heavy_check_mark: |
| 8.0.z | :heavy_check_mark: |
| 7.4.z | :heavy_check_mark: |
| 7.2.z | :heavy_check_mark: |
Expand Down
2 changes: 1 addition & 1 deletion packages/bloom/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import RedisBloomModules from '.';
export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.2-rc2-pre'
defaultDockerVersion: '8.2'
});

export const GLOBAL = {
Expand Down
32 changes: 16 additions & 16 deletions packages/client/lib/sentinel/test-util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,16 +174,16 @@ export class SentinelFramework extends DockerBase {
this.#testUtils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.2-rc2-pre'
defaultDockerVersion: '8.2'
});
this.#nodeMap = new Map<string, ArrayElement<Awaited<ReturnType<SentinelFramework['spawnRedisSentinelNodes']>>>>();
this.#sentinelMap = new Map<string, ArrayElement<Awaited<ReturnType<SentinelFramework['spawnRedisSentinelSentinels']>>>>();
}

getSentinelClient(opts?: Partial<RedisSentinelOptions<RedisModules,
getSentinelClient(opts?: Partial<RedisSentinelOptions<RedisModules,
RedisFunctions,
RedisScripts,
RespVersions,
RespVersions,
TypeMapping>>, errors = true) {
if (opts?.sentinelRootNodes !== undefined) {
throw new Error("cannot specify sentinelRootNodes here");
Expand Down Expand Up @@ -252,7 +252,7 @@ export class SentinelFramework extends DockerBase {

protected async spawnRedisSentinelNodes(replicasCount: number) {
const master = await this.#testUtils.spawnRedisServer({serverArguments: DEBUG_MODE_ARGS})

const replicas: Array<RedisServerDocker> = []
for (let i = 0; i < replicasCount; i++) {
const replica = await this.#testUtils.spawnRedisServer({serverArguments: DEBUG_MODE_ARGS})
Expand Down Expand Up @@ -282,7 +282,7 @@ export class SentinelFramework extends DockerBase {
async getAllRunning() {
for (const port of this.getAllNodesPort()) {
let first = true;
while (await isPortAvailable(port)) {
while (await isPortAvailable(port)) {
if (!first) {
console.log(`problematic restart ${port}`);
await setTimeout(500);
Expand All @@ -295,7 +295,7 @@ export class SentinelFramework extends DockerBase {

for (const port of this.getAllSentinelsPort()) {
let first = true;
while (await isPortAvailable(port)) {
while (await isPortAvailable(port)) {
if (!first) {
await setTimeout(500);
} else {
Expand Down Expand Up @@ -325,17 +325,17 @@ export class SentinelFramework extends DockerBase {
await client.connect();
await client.replicaOf("127.0.0.1", masterPort);
await client.close();


this.#nodeList.push(replica);
this.#nodeMap.set(replica.port.toString(), replica);
}

async getMaster(tracer?: Array<string>): Promise<string | undefined> {
const client = RedisClient.create({
name: this.config.sentinelName,
name: this.config.sentinelName,
socket: {
host: "127.0.0.1",
host: "127.0.0.1",
port: this.#sentinelList[0].port,
},
modules: RedisSentinelModule,
Expand Down Expand Up @@ -464,9 +464,9 @@ export class SentinelFramework extends DockerBase {

async sentinelSentinels() {
const client = RedisClient.create({
name: this.config.sentinelName,
name: this.config.sentinelName,
socket: {
host: "127.0.0.1",
host: "127.0.0.1",
port: this.#sentinelList[0].port,
},
modules: RedisSentinelModule,
Expand All @@ -480,9 +480,9 @@ export class SentinelFramework extends DockerBase {

async sentinelMaster() {
const client = RedisClient.create({
name: this.config.sentinelName,
name: this.config.sentinelName,
socket: {
host: "127.0.0.1",
host: "127.0.0.1",
port: this.#sentinelList[0].port,
},
modules: RedisSentinelModule,
Expand All @@ -496,9 +496,9 @@ export class SentinelFramework extends DockerBase {

async sentinelReplicas() {
const client = RedisClient.create({
name: this.config.sentinelName,
name: this.config.sentinelName,
socket: {
host: "127.0.0.1",
host: "127.0.0.1",
port: this.#sentinelList[0].port,
},
modules: RedisSentinelModule,
Expand All @@ -509,4 +509,4 @@ export class SentinelFramework extends DockerBase {

return replicas
}
}
}
2 changes: 1 addition & 1 deletion packages/client/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import RedisBloomModules from '@redis/bloom';
const utils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.2-rc2-pre'
defaultDockerVersion: '8.2'
});

export default utils;
Expand Down
2 changes: 1 addition & 1 deletion packages/entraid/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { EntraidCredentialsProvider } from './entraid-credentials-provider';
export const testUtils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.2-rc2-pre'
defaultDockerVersion: '8.2'
});

const DEBUG_MODE_ARGS = testUtils.isVersionGreaterThan([7]) ?
Expand Down
2 changes: 1 addition & 1 deletion packages/json/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import RedisJSON from '.';
export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.2-rc2-pre'
defaultDockerVersion: '8.2'
});

export const GLOBAL = {
Expand Down
2 changes: 1 addition & 1 deletion packages/search/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { RespVersions } from '@redis/client';
export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.2-rc2-pre'
defaultDockerVersion: '8.2'
});

export const GLOBAL = {
Expand Down
2 changes: 1 addition & 1 deletion packages/time-series/lib/test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import TimeSeries from '.';
export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: '8.2-rc2-pre'
defaultDockerVersion: '8.2'
});

export const GLOBAL = {
Expand Down
Loading