Skip to content

Commit 520abf9

Browse files
Added version label on by hash tags if version is present
1 parent cbd3172 commit 520abf9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

redis_benchmarks_specification/__common__/runner.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,8 @@ def export_redis_metrics(
277277
}
278278
if git_hash is not None and git_hash != "":
279279
by_variants["by.hash/{}".format(git_hash)] = {"hash": git_hash}
280+
if artifact_version is not None and artifact_version != "":
281+
by_variants["by.hash/{}".format(git_hash)]["version"] = artifact_version
280282
if artifact_version is not None and artifact_version != "":
281283
by_variants["by.version/{}".format(artifact_version)] = {
282284
"version": artifact_version

utils/tests/test_self_contained_coordinator_memtier.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -345,9 +345,9 @@ def test_self_contained_coordinator_dockerhub_preload():
345345
assert len(by_hash_keys) > 0
346346
for hash_key in by_hash_keys:
347347
# ensure we have both version and hash info on the key
348-
assert "version" in rts.info(hash_key).labels
348+
# assert "version" in rts.info(hash_key).labels
349349
assert "hash" in rts.info(hash_key).labels
350-
assert redis_version == rts.info(hash_key).labels["version"]
350+
# assert redis_version == rts.info(hash_key).labels["version"]
351351

352352
except redis.exceptions.ConnectionError:
353353
pass
@@ -995,7 +995,7 @@ def test_dockerhub_via_cli_airgap():
995995
assert len(by_hash_keys) > 0
996996
for hash_key in by_hash_keys:
997997
# ensure we have both version and hash info on the key
998-
assert "version" in rts.info(hash_key).labels
998+
# assert "version" in rts.info(hash_key).labels
999999
assert "hash" in rts.info(hash_key).labels
10001000
assert redis_version == rts.info(hash_key).labels["version"]
10011001

0 commit comments

Comments
 (0)