Remove nil/null reply description from ZADD command

[moznion]

This command doesn't return nil/null reply even if the NX/XX/LT/GT options are conflict; in that case, it returns the error reply like the following:

zadd z XX NX 1 foo
-ERR XX and NX options at the same time are not compatible
zadd z NX GT 1 foo
-ERR GT, LT, and/or NX options at the same time are not compatible
zadd z LT GT 1 foo
-ERR GT, LT, and/or NX options at the same time are not compatible

[netlify]

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	48b7278

[zuiderkwast]

Interesting. Can you find the PR where this was changed in redis?

[zuiderkwast]

You are right that an error is returned when the options conflict, but ZADD can still return null in some cases. See the test case "ZADD INCR LT/GT replies with nill if score not updated" in tests/unit/type/zset.tcl.

127.0.0.1:6379> zadd ztmp 28 x
(integer) 1
127.0.0.1:6379> zadd ztmp lt incr 1 x
(nil)

I think we should change the description to something like "... if the score was not updated when INCR was combined with LT/GT options" similar to what is used in the test case.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}