added return_fields function, attempting to optionally limit fields r… #633
+95
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs333
reviewed
Jul 5, 2024
slorello89
requested changes
Aug 19, 2024
|
Please add also exclude keyword, it'll be convenient |
|
Are u going to finish it guys? |
|
I tried to do it, and I found two main problems here:
|
bsbodden
added a commit
that referenced
this pull request
Aug 12, 2025
- Move RETURN clause from query string to args list (fixes RediSearch syntax) - Rename internal parameter from return_fields to projected_fields to avoid conflict with method name - Return dictionaries instead of model instances when using field projection - Add proper parsing for projected results that returns flat key-value pairs - Add tests for both HashModel and JsonModel field projection - Update validation to use model_fields instead of deprecated __fields__ This addresses all review comments from PR #633 and implements field projection correctly.
bsbodden
force-pushed
the
limit_return_fields
branch
from
3de85c9 to
8fc78fc
Compare
bsbodden
added a commit
that referenced
this pull request
Aug 12, 2025
- Move RETURN clause from query string to args list (fixes RediSearch syntax) - Rename internal parameter from return_fields to projected_fields to avoid conflict with method name - Return dictionaries instead of model instances when using field projection - Add proper parsing for projected results that returns flat key-value pairs - Add tests for both HashModel and JsonModel field projection - Update validation to use model_fields instead of deprecated __fields__ This addresses all review comments from PR #633 and implements field projection correctly.
bsbodden
force-pushed
the
limit_return_fields
branch
from
8fc78fc to
5b91067
Compare
- Move RETURN clause from query string to args list (fixes RediSearch syntax) - Rename internal parameter from return_fields to projected_fields to avoid conflict with method name - Return dictionaries instead of model instances when using field projection - Add proper parsing for projected results that returns flat key-value pairs - Add tests for both HashModel and JsonModel field projection - Update validation to use model_fields instead of deprecated __fields__ This addresses all review comments from PR #633 and implements field projection correctly.
bsbodden
force-pushed
the
limit_return_fields
branch
from
5b91067 to
b997389
Compare
bsbodden
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eturned by find. Will solve #568 when completed.