Skip to content

Conversation

@bsbodden
Copy link
Collaborator

No description provided.

…ration

- Fix NUMERIC_IN to not escape numeric values (dots in decimals were being escaped)
- Add missing NUMERIC_NOT_IN implementation using RediSearch negation pattern
- Add support for arrays/varargs parameters in collection queries
- Handle empty collections correctly (NUMERIC_IN returns no results, NOT_IN returns all)
- Fix query combination for multiple values using proper OR syntax with parentheses

test: add comprehensive tests for numeric IN/NOT_IN queries

- Add NumericInQueryTest with 17 test cases covering all numeric types
- Add NumericIndexedIdFieldTest to verify @NumericIndexed on @id fields
- Add NumericInQueryClauseTest for enum verification
- Add metamodel generator test for @NumericIndexed ID fields
- Test edge cases: empty collections, single values, large numbers, nullables

Fixes issues found in PR redis#645 where NUMERIC_IN had syntax errors and
NUMERIC_NOT_IN was not implemented. All tests now pass.
@bsbodden bsbodden self-assigned this Aug 19, 2025
@bsbodden bsbodden merged commit 5a6d4a6 into redis:main Aug 19, 2025
1 check passed
@bsbodden bsbodden deleted the bsb/numeric-in branch November 26, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant