Skip to content

fix: change auto-service scope from implementation to compileOnly #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

fix: change auto-service scope from implementation to compileOnly #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redis-om-spring/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ dependencies {
api "com.squareup:javapoet:${javapoetVersion}"

compileOnly "javax.enterprise:cdi-api:${cdi}"
implementation "com.google.auto.service:auto-service:${autoServiceVersion}"
compileOnly "com.google.auto.service:auto-service:${autoServiceVersion}"
annotationProcessor "com.google.auto.service:auto-service:${autoServiceVersion}"
}
22 changes: 22 additions & 0 deletions tests/src/test/java/com/redis/om/spring/metamodel/MetamodelGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

import javax.annotation.processing.Processor;
import javax.tools.JavaFileObject;
import java.io.IOException;
import java.util.List;
import java.util.Locale;
import java.util.ServiceLoader;
import java.util.stream.Collectors;

import static org.assertj.core.api.Assertions.assertThat;
Expand All @@ -30,6 +32,26 @@
{ MetamodelGenerator.class }
)
class MetamodelGeneratorTest {

@Test
void testAnnotationProcessorServiceRegistration() {
// Verify that MetamodelGenerator is properly registered as a service
// This ensures that the @AutoService annotation is working correctly
ServiceLoader<Processor> loader = ServiceLoader.load(Processor.class);
boolean foundMetamodelGenerator = false;

for (Processor processor : loader) {
if (processor instanceof MetamodelGenerator) {
foundMetamodelGenerator = true;
break;
}
}

assertThat(foundMetamodelGenerator)
.as("MetamodelGenerator should be discoverable via ServiceLoader")
.isTrue();
}

@Test
@Classpath(
"data.metamodel.ValidDocumentIndexed"
Expand Down