fix: correct confusing parameter order in AggregationStream.limit() (… #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edis#646) Changed the parameter order of AggregationStream.limit() from (limit, offset) to (offset, limit) to match Spring Data conventions and user expectations. The previous order was counterintuitive as most frameworks (Spring Data Pageable, SQL, Jedis) use offset first. Changes: - Updated AggregationStream interface method signature - Fixed AggregationStreamImpl to match new parameter order - Updated QBE implementations in SimpleRedisDocumentRepository and SimpleRedisEnhancedRepository - Added test coverage for the corrected parameter order - Updated documentation to reflect the new parameter order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#646)
Changed the parameter order of AggregationStream.limit() from (limit, offset) to (offset, limit) to match Spring Data conventions and user expectations. The previous order was counterintuitive as most frameworks (Spring Data Pageable, SQL, Jedis) use offset first.
Changes: