fix: support findByIdIn queries on auto-indexed @Id fields (#699) #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extractQueryFields method in RediSearchQuery and RedisEnhancedQuery only checked for explicit index annotations (@NumericIndexed, @TagIndexed, etc.) but did not handle @id fields that are automatically indexed by RediSearchIndexer. This caused findByIdIn queries to return incorrect results (all records or no filtering) when the @id field had no explicit index annotation. The fix adds handling for @id fields in extractQueryFields(): - Number types (Long, Integer, etc.) -> NUMERIC field type - String, UUID, Ulid, etc. -> TAG field type This matches the auto-indexing behavior in RediSearchIndexer where @id fields are automatically indexed based on their Java type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extractQueryFields method in RediSearchQuery and RedisEnhancedQuery only checked for explicit index annotations (@NumericIndexed, @TagIndexed, etc.) but did not handle @id fields that are automatically indexed by RediSearchIndexer.
This caused findByIdIn queries to return incorrect results (all records or no filtering) when the @id field had no explicit index annotation.
The fix adds handling for @id fields in extractQueryFields():
This matches the auto-indexing behavior in RediSearchIndexer where @id fields are automatically indexed based on their Java type.