Skip to content

fix: use locale-agnostic uppercase in metamodel generator (#700) #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsbodden merged 2 commits into from
Dec 8, 2025
Merged

fix: use locale-agnostic uppercase in metamodel generator (#700) #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f10e3
fix: use locale-agnostic uppercase in metamodel generator (#700)
bsbodden Dec 8, 2025
ebafe3b
Merge branch 'main' into bsb/issue-700
bsbodden Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions redis-om-spring/src/main/java/com/redis/om/spring/metamodel/MetamodelGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ else if (Map.class.isAssignableFrom(targetCls)) {
// Generate the special VALUES field for querying map values
if (valuesInterceptor != null) {
String mapFieldName = field.getSimpleName().toString();
String mapValuesFieldName = mapFieldName.toUpperCase().replace("_", "") + "_VALUES";
String mapValuesFieldName = mapFieldName.toUpperCase(Locale.ROOT).replace("_", "") + "_VALUES";

// Add the VALUES field as a special metamodel field
Triple<ObjectGraphFieldSpec, FieldSpec, CodeBlock> valuesField = generateMapValuesFieldMetamodel(entity,
Expand All @@ -518,8 +518,8 @@ else if (Map.class.isAssignableFrom(targetCls)) {
if (subfieldElement.getAnnotation(com.redis.om.spring.annotations.Indexed.class) != null) {
String subfieldName = subfieldElement.getSimpleName().toString();
String jsonFieldName = getJsonFieldName(subfieldElement);
String nestedFieldName = field.getSimpleName().toString().toUpperCase().replace("_",
"") + "_" + subfieldName.toUpperCase().replace("_", "");
String nestedFieldName = field.getSimpleName().toString().toUpperCase(Locale.ROOT).replace("_",
"") + "_" + subfieldName.toUpperCase(Locale.ROOT).replace("_", "");

TypeMirror subfieldTypeMirror = subfieldElement.asType();
String subfieldTypeName = subfieldTypeMirror.toString();
Expand Down
2 changes: 1 addition & 1 deletion redis-om-spring/src/main/java/com/redis/om/spring/util/ObjectUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ public static String replaceIfIllegalJavaIdentifierCharacter(final String word)
*/
public static String staticField(final String externalName) {
requireNonNull(externalName);
return ObjectUtils.toUnderscoreSeparated(javaNameFromExternal(externalName)).toUpperCase();
return ObjectUtils.toUnderscoreSeparated(javaNameFromExternal(externalName)).toUpperCase(java.util.Locale.ROOT);
}

/**
Expand Down