Skip to content

Fixed bug with SLOWLOG GET response parsing from Redis Software #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fixed bug with SLOWLOG GET response parsing from Redis Software #3441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d9624e
Fixed bug with SLOWLOG GET response parsing from Redis Enterprise
vladvildanov Nov 19, 2024
0c439d9
Merge branch 'master' into vv-slowlog-get-bug
vladvildanov Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions redis/_parsers/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,13 +396,20 @@ def parse_item(item):
# an O(N) complexity) instead of the command.
if isinstance(item[3], list):
result["command"] = space.join(item[3])
result["client_address"] = item[4]
result["client_name"] = item[5]

# These fields are optional, depends on environment.
if len(item) >= 6:
result["client_address"] = item[4]
result["client_name"] = item[5]
else:
result["complexity"] = item[3]
result["command"] = space.join(item[4])
result["client_address"] = item[5]
result["client_name"] = item[6]

# These fields are optional, depends on environment.
if len(item) >= 7:
result["client_address"] = item[5]
result["client_name"] = item[6]

return result

return [parse_item(item) for item in response]
Expand Down
Loading