Skip to content

(tests): Added testing for auth via DefaultAzureCredential #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2025
Merged

(tests): Added testing for auth via DefaultAzureCredential #3544

merged 3 commits into from
Mar 6, 2025
+59 −14

Conversation

vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@vladvildanov vladvildanov added the maintenance Maintenance (CI, Releases, etc) label Mar 6, 2025
petyaslavova
petyaslavova approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vladvildanov vladvildanov merged commit 601c1aa into master Mar 6, 2025
37 checks passed
@vladvildanov vladvildanov deleted the vv-entraid-default-azure branch March 6, 2025 11:24
petyaslavova pushed a commit to Kakadus/redis-py that referenced this pull request May 13, 2025
@vladvildanov @petyaslavova
(tests): Added testing for auth via DefaultAzureCredential (redis#3544)
8a28b96 
* (tests): Added testing for auth via DefaultAzureCredential

* Added testing for async

* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petyaslavova petyaslavova petyaslavova approved these changes

Assignees

No one assigned

Labels

maintenance Maintenance (CI, Releases, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vladvildanov @petyaslavova