Skip to content

Fixing the versions of some deprecations that wrongly added as 5.0.3 - the correct version is 5.3.0 #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Fixing the versions of some deprecations that wrongly added as 5.0.3 - the correct version is 5.3.0 #3625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redis/asyncio/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def from_url(cls, url: str, **kwargs: Any) -> "RedisCluster":
@deprecated_args(
args_to_warn=["read_from_replicas"],
reason="Please configure the 'load_balancing_strategy' instead",
version="5.0.3",
version="5.3.0",
)
def __init__(
self,
Expand Down
4 changes: 2 additions & 2 deletions redis/asyncio/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@ def can_get_connection(self) -> bool:
@deprecated_args(
args_to_warn=["*"],
reason="Use get_connection() without args instead",
version="5.0.3",
version="5.3.0",
)
async def get_connection(self, command_name=None, *keys, **options):
async with self._lock:
Expand Down Expand Up @@ -1306,7 +1306,7 @@ def __init__(
@deprecated_args(
args_to_warn=["*"],
reason="Use get_connection() without args instead",
version="5.0.3",
version="5.3.0",
)
async def get_connection(self, command_name=None, *keys, **options):
"""Gets a connection from the pool, blocking until one is available"""
Expand Down
6 changes: 3 additions & 3 deletions redis/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def get_node_name(host: str, port: Union[str, int]) -> str:
@deprecated_args(
allowed_args=["redis_node"],
reason="Use get_connection(redis_node) instead",
version="5.0.3",
version="5.3.0",
)
def get_connection(redis_node, *args, **options):
return redis_node.connection or redis_node.connection_pool.get_connection()
Expand Down Expand Up @@ -490,7 +490,7 @@ class initializer. In the case of conflicting arguments, querystring
@deprecated_args(
args_to_warn=["read_from_replicas"],
reason="Please configure the 'load_balancing_strategy' instead",
version="5.0.3",
version="5.3.0",
)
def __init__(
self,
Expand Down Expand Up @@ -1493,7 +1493,7 @@ def _update_moved_slots(self):
"In case you need select some load balancing strategy "
"that will use replicas, please set it through 'load_balancing_strategy'"
),
version="5.0.3",
version="5.3.0",
)
def get_node_from_slot(
self,
Expand Down
4 changes: 2 additions & 2 deletions redis/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,7 +1502,7 @@ def _checkpid(self) -> None:
@deprecated_args(
args_to_warn=["*"],
reason="Use get_connection() without args instead",
version="5.0.3",
version="5.3.0",
)
def get_connection(self, command_name=None, *keys, **options) -> "Connection":
"Get a connection from the pool"
Expand Down Expand Up @@ -1730,7 +1730,7 @@ def make_connection(self):
@deprecated_args(
args_to_warn=["*"],
reason="Use get_connection() without args instead",
version="5.0.3",
version="5.3.0",
)
def get_connection(self, command_name=None, *keys, **options):
"""
Expand Down
Loading