Skip to content

Add abstractmethod declaration #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

Conversation

mengxunQAQ
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add an abstractmethod declaration to ensure that subclasses do not forget to implement this method.

@petyaslavova
Copy link
Collaborator

Hi @mengxunQAQ, thank you for your contribution! We’ll review your change soon.

@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Aug 12, 2025
@petyaslavova petyaslavova added the breakingchange API or Breaking Change label Aug 12, 2025
@petyaslavova petyaslavova merged commit 349d761 into redis:master Aug 12, 2025
64 of 66 checks passed
petyaslavova pushed a commit to elena-kolevska/redis-py that referenced this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants